Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rspec workflow in CI, add Rails 8 to matrix #254

Merged
merged 4 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 29 additions & 22 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,65 +12,76 @@ jobs:
env:
BUNDLE_JOBS: 4
BUNDLE_RETRY: 3
BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}
CI: true
RAILS_ENV: test
DATABASE_URL: postgres://postgres:postgres@localhost:5432
strategy:
fail-fast: false
matrix:
ruby: ["3.1"]
postgres: ["12"]
ruby: ["3.4"]
postgres: ["16"]
gemfile: [
"gemfiles/rails72.gemfile"
rails8.gemfile
]
fx: ["false"]
after_trigger: ["false"]
include:
- ruby: "3.2"
- ruby: "3.4"
postgres: "16"
gemfile: rails8.gemfile
fx: "false"
after_trigger: "false"
- ruby: "3.3"
postgres: "16"
gemfile: rails8.gemfile
fx: "false"
after_trigger: "true"
- ruby: "3.3"
postgres: "16"
gemfile: rails72.gemfile
fx: "false"
after_trigger: "false"
- ruby: "3.3"
postgres: "15"
gemfile: "gemfiles/railsmaster.gemfile"
gemfile: railsmaster.gemfile
fx: "false"
after_trigger: "false"
- ruby: "3.2"
postgres: "15"
gemfile: "gemfiles/rails72.gemfile"
gemfile: rails72.gemfile
fx: "false"
after_trigger: "false"
- ruby: "3.2"
postgres: "15"
gemfile: "gemfiles/rails71.gemfile"
gemfile: rails71.gemfile
fx: "false"
after_trigger: "false"
- ruby: "3.2"
postgres: "15"
gemfile: "gemfiles/rails70.gemfile"
gemfile: rails70.gemfile
fx: "false"
after_trigger: "false"
- ruby: "3.1"
postgres: "12"
gemfile: "gemfiles/rails72.gemfile"
gemfile: rails72.gemfile
fx: "false"
after_trigger: "true"
- ruby: "3.0"
postgres: "13"
gemfile: "gemfiles/rails72.gemfile"
fx: "false"
after_trigger: "false"
- ruby: "2.7"
postgres: "13"
gemfile: "gemfiles/rails6.gemfile"
gemfile: rails6.gemfile
fx: "false"
after_trigger: "false"
table_name_prefix: 'prefix-'
table_name_suffix: '-suffix'
- ruby: "2.7"
postgres: "11"
gemfile: "gemfiles/rails6.gemfile"
gemfile: rails6.gemfile
fx: "false"
after_trigger: "true"
- ruby: "2.7"
postgres: "10"
gemfile: "gemfiles/rails6.gemfile"
gemfile: rails6.gemfile
fx: "false"
after_trigger: "false"
services:
Expand All @@ -85,11 +96,7 @@ jobs:
--health-timeout 5s
--health-retries 5
steps:
- uses: actions/checkout@v3
- name: Install system deps
run: |
sudo apt-get update
sudo apt-get -yqq install libpq-dev
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
Expand Down
9 changes: 9 additions & 0 deletions gemfiles/rails8.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
source 'https://rubygems.org'

rails_version = '~> 8.0.0'
gem 'railties', rails_version
gem 'activerecord', rails_version

eval_gemfile './shared.gemfile'

gemspec path: '..'
1 change: 1 addition & 0 deletions logidze.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rake", ">= 13.0"
spec.add_development_dependency "rspec-rails", ">= 4.0"
spec.add_development_dependency "timecop", "~> 0.8"
spec.add_development_dependency "concurrent-ruby", "1.3.4" # Remove once https://github.com/rails/rails/issues/54263 is resolved
end
Loading