Fix Rspec workflow in CI, add Rails 8 to matrix #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes Rails 7.2 against Ruby 3.0, as it required 3.1
palkan
requested changes
Jan 27, 2025
logidze.gemspec
Outdated
| @@ -29,6 +29,7 @@ Gem::Specification.new do |spec| | |||
| rails_version = ">= 6.0" | |||
| spec.add_dependency "railties", rails_version | |||
| spec.add_dependency "activerecord", rails_version | |||
| spec.add_dependency "concurrent-ruby", "1.3.4" | |||
There was a problem hiding this comment.
Let's make a development dependency for now; we shouldn't freeze indirect dependencies for end users, and for us that would be enough.
And could you please add a comment with the link to the issue? (So we can drop it as it's resolved)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
fd67403 fixes the Rspec matrix in CI - this was broken in 2023, as the env variable to set the gemfile was added to other workflow files, but not the rsped one.
dfd2b27 modernizes the workflow (no need to manually install libpq anymore)
83480a8 adds Rails 8 to the matrix and modernizes the ruby/postgres versions the gem is tested with.
77d350f is needed due to rails/rails#54263, don't think it is desirable to merge.
What changes did you make? (overview)
Is there anything you'd like reviewers to focus on?
The specs fail against Rails master, unsure how to fix atm.
Checklist