Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [CHK-2860] Make authorizationUrl redirection as env variables #500

Merged
merged 4 commits into from
May 28, 2024
Merged

fix: [CHK-2860] Make authorizationUrl redirection as env variables #500

merged 4 commits into from
May 28, 2024

Conversation

petretiandrea
Copy link
Contributor

@petretiandrea petretiandrea commented May 24, 2024 •
edited
Loading

Make authorizationUrl redirection url as environment variabile to provide a simple way to change them. This PR block #498

List of Changes

Motivation and Context

Make easy the change of Outcome and Gdi check URLs

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@petretiandrea petretiandrea requested a review from a team as a code owner May 24, 2024 06:06
@petretiandrea petretiandrea mentioned this pull request May 24, 2024
Open
5 tasks
pietro-tota
pietro-tota previously approved these changes May 24, 2024
View reviewed changes
@petretiandrea petretiandrea requested a review from pietro-tota May 27, 2024 07:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
78 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@petretiandrea petretiandrea merged commit b747e93 into main May 28, 2024
7 checks passed
@petretiandrea petretiandrea deleted the CHK-2860-authurl-move-env branch May 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infantesimone infantesimone infantesimone approved these changes

@pietro-tota pietro-tota pietro-tota approved these changes

Assignees
No one assigned
Labels
chart-patch patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petretiandrea @infantesimone @pietro-tota