Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [CHK-2860] Update gdi check url to redirect to ecommerce-fe #498

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: [CHK-2860] Update gdi check url to redirect to ecommerce-fe #498

wants to merge 13 commits into from

Conversation

petretiandrea
Copy link
Contributor

@petretiandrea petretiandrea commented May 21, 2024 •
edited
Loading

List of Changes

  • checkout and wallet now shares the same gdi-check url -> redirect to ecommerce-fe
  • update tests

Motivation and Context

Move GDI check from checkout-fe to ecommerce-fe

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@petretiandrea petretiandrea mentioned this pull request May 21, 2024
Open
5 tasks
@petretiandrea petretiandrea marked this pull request as ready for review May 21, 2024 16:02
@petretiandrea petretiandrea requested a review from a team as a code owner May 21, 2024 16:02
@petretiandrea petretiandrea mentioned this pull request May 22, 2024
Open
5 tasks
@petretiandrea petretiandrea mentioned this pull request May 24, 2024
Merged
5 tasks
petretiandrea
petretiandrea commented May 24, 2024
View reviewed changes
Copy link
Contributor Author

@petretiandrea petretiandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locked by #500

@petretiandrea petretiandrea mentioned this pull request May 24, 2024
Merged
5 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
78 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@petretiandrea petretiandrea changed the base branch from main to CHK-2860-authurl-move-env May 27, 2024 07:29
Base automatically changed from CHK-2860-authurl-move-env to main May 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chart-minor minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petretiandrea