chore: [IOBP-660] Add remote feature flag to the new payment section #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 69.87% 69.78% -0.10%
==========================================
Files 153 156 +3
Lines 4886 4997 +111
Branches 562 605 +43
==========================================
+ Hits 3414 3487 +73
+ Misses 1471 1432 -39
- Partials 1 78 +77
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mastro993
approved these changes
May 29, 2024
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
May 29, 2024
…5798) ##⚠️ This PR depends on pagopa/io-services-metadata#782⚠️ ## Short description This PR adds the remote feature flag to the new payment section. It will be visible only when the remote or local FF is enabled. (The local feature flag is considered only if the remote one is disabled) ## List of changes proposed in this pull request - Added a new `isNewPaymentSectionEnabledSelector` selector that takes into account remote configuration - Replaced the previous `isNewWalletSectionEnabledSelector` with this new one but the previous one is still available in order to show the local feature flag. ## How to test - Checkout this PR: pagopa/io-dev-api-server#383 - Try to change the `enabled` attribute from the `newPaymentSection` into the `backend.ts` file on the dev-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a mock remote feature flag to the new payment section
List of changes proposed in this pull request
newPaymentSectionfrom thebackend.tsfile