Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-659] Add remote feature flag to the new payment section #5798

Merged
merged 13 commits into from
May 29, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 27, 2024

⚠️ This PR depends on pagopa/io-services-metadata#782 ⚠️

Short description

This PR adds the remote feature flag to the new payment section. It will be visible only when the remote or local FF is enabled. (The local feature flag is considered only if the remote one is disabled)

List of changes proposed in this pull request

  • Added a new isNewPaymentSectionEnabledSelector selector that takes into account remote configuration
  • Replaced the previous isNewWalletSectionEnabledSelector with this new one but the previous one is still available in order to show the local feature flag.

How to test

@Hantex9 Hantex9 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label May 27, 2024
@Hantex9 Hantex9 requested a review from a team as a code owner May 27, 2024 14:41
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 27, 2024

Affected stories

  • ⚙️ IOBP-659: Mostrare i nuovi flussi in app prendendo in considerazione il FF remoto
    subtask of
    • ⚙️ IOBP-608: Protezione nuovi sviluppi sotto FF remoto

Generated by 🚫 dangerJS against 272ad37

Copy link

dpulls bot commented May 27, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hantex9 added 2 commits May 27, 2024 17:45
… 'IOBP-659-remote-feature-flag-new-payment-section' of https://github.com/pagopa/io-app into IOBP-659-remote-feature-flag-new-payment-section
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.71%. Comparing base (4f204b4) to head (272ad37).
Report is 110 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5798      +/-   ##
==========================================
+ Coverage   48.42%   49.71%   +1.29%     
==========================================
  Files        1488     1630     +142     
  Lines       31617    32428     +811     
  Branches     7669     7842     +173     
==========================================
+ Hits        15311    16123     +812     
- Misses      16238    16242       +4     
+ Partials       68       63       -5     
Files Coverage Δ
...atures/payments/checkout/hooks/usePagoPaPayment.ts 8.69% <ø> (ø)
ts/navigation/AppStackNavigator.tsx 42.85% <ø> (-1.15%) ⬇️
ts/navigation/AuthenticatedStackNavigator.tsx 10.00% <ø> (-1.12%) ⬇️
ts/navigation/TabNavigator.tsx 9.09% <ø> (-1.72%) ⬇️
.../navigation/components/HeaderFirstLevelHandler.tsx 6.45% <ø> (ø)
ts/store/reducers/__mock__/backendStatus.ts 66.66% <ø> (ø)
ts/store/reducers/backendStatus.ts 74.81% <100.00%> (+1.73%) ⬆️

... and 562 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15086be...272ad37. Read the comment docs.

@Hantex9 Hantex9 merged commit a3854c1 into master May 29, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-659-remote-feature-flag-new-payment-section branch May 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants