Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPAE-1118] Add institution's services endpoint #372

Merged
merged 6 commits into from
May 7, 2024

Conversation

adelloste
Copy link
Member

Short description

This PR adds GET /institutions/:institutionId/services endpoint

List of changes proposed in this pull request

  • Added GET /institutions/:institutionId/services endpoint to retrieve the institution's services.

How to test

You can test this PR using a REST client

@adelloste adelloste requested a review from a team as a code owner April 29, 2024 12:40
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 27.77778% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 69.74%. Comparing base (141ec79) to head (9fdaed3).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   70.02%   69.74%   -0.28%     
==========================================
  Files         151      152       +1     
  Lines        4794     4826      +32     
  Branches      573      576       +3     
==========================================
+ Hits         3357     3366       +9     
- Misses       1363     1383      +20     
- Partials       74       77       +3     
Files Coverage Δ
src/config.ts 96.00% <ø> (ø)
src/features/services/types/configuration.ts 100.00% <ø> (ø)
src/features/services/payloads/get-institutions.ts 26.47% <50.00%> (+2.22%) ⬆️
...c/features/services/payloads/get-featured-items.ts 42.10% <25.00%> (-4.96%) ⬇️
src/features/services/routers/institutions.ts 40.62% <16.66%> (-11.76%) ⬇️
src/features/services/payloads/get-services.ts 33.33% <33.33%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f910d6...9fdaed3. Read the comment docs.

Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste merged commit bd49946 into master May 7, 2024
8 checks passed
@adelloste adelloste deleted the IOPAE-1118-services-by-institution-id branch May 7, 2024 09:48
adelloste added a commit to pagopa/io-app that referenced this pull request May 7, 2024
…5744)

This PR depends on #5739

## Short description
This PR handles failure state when fetching the institution's services.

## List of changes proposed in this pull request
- added InstitutionServicesFailure component
- updated InstitutionServicesScreen to manage failure state

## How to test
Using `io-dev-api-server`, checkout this PR
pagopa/io-dev-api-server#372, set the status
code to 500. Navigate to the services tab and tap on an institution.
Check the error card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants