Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPAE-1126] Add failure state to InstitutionServicesScreen #5744

Merged
merged 11 commits into from
May 7, 2024

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented May 6, 2024

This PR depends on #5739

Short description

This PR handles failure state when fetching the institution's services.

List of changes proposed in this pull request

  • added InstitutionServicesFailure component
  • updated InstitutionServicesScreen to manage failure state

How to test

Using io-dev-api-server, checkout this PR pagopa/io-dev-api-server#372, set the status code to 500. Navigate to the services tab and tap on an institution. Check the error card

@adelloste adelloste added the IO-Enti e Servizi IO - Enti e Servizi label May 6, 2024
@adelloste adelloste requested review from thisisjp and a team as code owners May 6, 2024 09:17
@pagopa-github-bot pagopa-github-bot changed the title [IOPAE-1126] Add failure state to InstitutionServicesScreen chore: [IOPAE-1126] Add failure state to InstitutionServicesScreen May 6, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 6, 2024

Affected stories

  • ⚙️ IOPAE-1126: [APP] Aggiungere screen di errore
    subtask of
    • 🌟 IOPAE-1107: [MVP0] Come utente voglio vedere una Pagina Ente con tutti i servizi dell'ente

Generated by 🚫 dangerJS against 26cffcb

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.04%. Comparing base (4f204b4) to head (26cffcb).
Report is 54 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
+ Coverage   48.42%   49.04%   +0.62%     
==========================================
  Files        1488     1597     +109     
  Lines       31617    32112     +495     
  Branches     7669     7832     +163     
==========================================
+ Hits        15311    15750     +439     
- Misses      16238    16294      +56     
  Partials       68       68              
Files Coverage Δ
...titution/components/InstitutionServicesFailure.tsx 100.00% <100.00%> (ø)
.../components/InstitutionServicesScreenComponent.tsx 90.00% <100.00%> (ø)
.../institution/screens/InstitutionServicesScreen.tsx 80.55% <100.00%> (ø)

... and 199 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5010ac...26cffcb. Read the comment docs.

Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste merged commit 2f24bba into master May 7, 2024
13 checks passed
@adelloste adelloste deleted the IOPAE-1126-failure-state branch May 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Enti e Servizi IO - Enti e Servizi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants