Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-1742] change CDN urls #371

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

Ladirico
Copy link
Contributor

Short description

Change CDN urls from assets.cdn.io.italia.it to assets.cdn.io.pagopa.it for all occurrence

How to test

Verify that each link works identically to the as-is

@Ladirico Ladirico added the help wanted Extra attention is needed label Apr 24, 2024
@Ladirico Ladirico self-assigned this Apr 24, 2024
@Ladirico Ladirico requested a review from a team as a code owner April 24, 2024 12:19
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the UA's section

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Wallet's section

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (43f2bd3) to head (16809ea).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files         151      151           
  Lines        4791     4791           
  Branches      552      552           
=======================================
  Hits         3357     3357           
  Misses       1433     1433           
  Partials        1        1           
Files Coverage Δ
src/payloads/backend.ts 100.00% <ø> (ø)
src/payloads/wallet.ts 95.08% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af97362...16809ea. Read the comment docs.

Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ladirico Ladirico merged commit 465d53c into master May 2, 2024
8 checks passed
@Ladirico Ladirico deleted the IOPID-1742-change-assets-cdn branch May 2, 2024 13:13
Ladirico added a commit to pagopa/io-app that referenced this pull request May 2, 2024
> [!Warning]
> This PR depends on
pagopa/io-services-metadata#779 and
pagopa/io-dev-api-server#371

## Short description
Change CDN urls from assets.cdn.io.italia.it to assets.cdn.io.pagopa.it
for all occurrence

## How to test
Verify that each link works identically to the as-is

Co-authored-by: Fabio Bombardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants