Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-1743] Change CDN urls #5719

Merged
merged 9 commits into from
May 2, 2024
Merged

Conversation

Ladirico
Copy link
Contributor

Short description

Change CDN urls from assets.cdn.io.italia.it to assets.cdn.io.pagopa.it for all occurrence

How to test

Verify that each link works identically to the as-is

@Ladirico Ladirico self-assigned this Apr 24, 2024
@Ladirico Ladirico requested review from dmnplb and a team as code owners April 24, 2024 12:26
@Ladirico Ladirico changed the title change urls from assets.cdn.io.italia.it to assets.cdn.io.pagopa.it [IOPID-1743] Change CDN urls Apr 24, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOPID-1743] Change CDN urls chore: [IOPID-1743] Change CDN urls Apr 24, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Apr 24, 2024

Affected stories

  • ⚙️ IOPID-1743: [APP] Modifica puntamenti in app
    subtask of
    • ⚙️ IOPID-1741: [APP] Modifica puntamenti CDN da io.italia.it a io.pagopa.it

Generated by 🚫 dangerJS against 34e69b1

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the messages' section

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.86%. Comparing base (4f204b4) to head (34e69b1).
Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5719      +/-   ##
==========================================
+ Coverage   48.42%   48.86%   +0.43%     
==========================================
  Files        1488     1584      +96     
  Lines       31617    31872     +255     
  Branches     7669     7722      +53     
==========================================
+ Hits        15311    15574     +263     
+ Misses      16238    16230       -8     
  Partials       68       68              
Files Coverage Δ
ts/config.ts 100.00% <100.00%> (ø)
ts/features/design-system/core/DSListItems.tsx 26.66% <100.00%> (ø)
ts/features/design-system/core/DSLogos.tsx 31.03% <100.00%> (ø)

... and 123 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dece582...34e69b1. Read the comment docs.

Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

dpulls bot commented May 2, 2024

🎉 All dependencies have been resolved !

@Ladirico Ladirico merged commit 110d548 into master May 2, 2024
13 checks passed
@Ladirico Ladirico deleted the IOPID-1743-change-assets-cdn branch May 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants