Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-1448] chore: add 409 management #345

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Feb 1, 2024

Short description

This PR adds the 409 error in the profile POST if the version is not the actual one based on io-functions-app UpdateProfile/handler.ts#L135

How to test

Test IO app against this branch. All must work fine.

@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label Feb 1, 2024
@shadowsheep1 shadowsheep1 self-assigned this Feb 1, 2024
@shadowsheep1 shadowsheep1 added dont-merge ✋🏼 and removed IO-A&I IO - Autenticazione e Identità labels Feb 1, 2024
@shadowsheep1 shadowsheep1 marked this pull request as ready for review February 1, 2024 10:37
@shadowsheep1 shadowsheep1 requested a review from a team as a code owner February 1, 2024 10:37
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (182ec31) 67.44% compared to head (d59d4e7) 70.59%.
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   67.44%   70.59%   +3.14%     
==========================================
  Files         156      141      -15     
  Lines        5265     4635     -630     
  Branches      636      544      -92     
==========================================
- Hits         3551     3272     -279     
+ Misses       1615     1362     -253     
+ Partials       99        1      -98     
Files Coverage Δ
src/config.ts 96.00% <ø> (ø)
src/features/wallet/payloads/transactions.ts 60.00% <ø> (ø)
src/persistence/services.ts 86.95% <ø> (-0.19%) ⬇️
src/populate-persistence.ts 83.52% <ø> (ø)
src/routers/features/cgn/index.ts 32.59% <100.00%> (ø)
src/routers/public.ts 67.46% <ø> (-0.51%) ⬇️
src/routers/services_metadata.ts 51.02% <ø> (+1.48%) ⬆️
src/server.ts 100.00% <ø> (ø)
src/types/config.ts 100.00% <ø> (ø)
src/utils/variables.ts 100.00% <ø> (ø)
... and 3 more

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a630f39...d59d4e7. Read the comment docs.

@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label Feb 8, 2024
Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowsheep1 shadowsheep1 merged commit 202bab7 into master Feb 13, 2024
6 checks passed
@Vangaorth Vangaorth deleted the IOPID-1448-409-conflict branch February 13, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants