Merge pull request #345 from pagopa/IOPID-1448-409-conflict

[IOPID-1448] chore: add 409 management
pagopa · Feb 13, 2024 · 202bab7 · 202bab7
2 parents a630f39 + d59d4e7
commit 202bab7
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/persistence/profile/profile.ts b/src/persistence/profile/profile.ts
@@ -36,7 +36,10 @@ export const updateProfile = (req: Request): ProfileOperationsType["post"] => {
   if (emailAlreadyTakenTestCheck) {
     return emailAlreadyTakenTestCheck;
   }
-
+  const profileVersionCheck = checkProfileVersion(maybeProfileToUpdate);
+  if (profileVersionCheck) {
+    return profileVersionCheck;
+  }
   const clientProfileIncreased: Profile = {
     ...maybeProfileToUpdate.right,
     version: parseInt(req.body.version, 10) + 1
@@ -108,6 +111,19 @@ export const setProfileEmailAlreadyTaken = (value: boolean) => {
   };
 };
 
+const checkProfileVersion = (profile: ReturnType<typeof Profile.decode>) => {
+  if (E.isRight(profile) && profile.right.version !== currentProfile.version) {
+    return {
+      status: profileProblemsList.conflict.status,
+      payload: getProblemJson(
+        profileProblemsList.conflict.status,
+        profileProblemsList.conflict.detail,
+        profileProblemsList.conflict.detail
+      )
+    };
+  }
+};
+
 const handleAlreadyTakenTestEmail = (
   email?: string
 ): CustomResponse | undefined => {
@@ -127,11 +143,15 @@ const handleAlreadyTakenTestEmail = (
 };
 
 // MARK: Problems
-type ProfileProblemDetail = "Precondition Failed" | "BodyMalformed";
+type ProfileProblemDetail =
+  | "Precondition Failed"
+  | "BodyMalformed"
+  | "Conflict";
 
 type ProfileProblems = {
   emailAlreadyTaken: ResponseProblem<ProfileProblemDetail>;
   bodyMalformed: ResponseProblem<ProfileProblemDetail>;
+  conflict: ResponseProblem<ProfileProblemDetail>;
 };
 
 const profileProblemsList: ProfileProblems = {
@@ -142,6 +162,10 @@ const profileProblemsList: ProfileProblems = {
   bodyMalformed: {
     status: 400,
     detail: "BodyMalformed"
+  },
+  conflict: {
+    status: 409,
+    detail: "Conflict"
   }
 };
 

diff --git a/src/routers/__tests__/profile.test.ts b/src/routers/__tests__/profile.test.ts
@@ -30,7 +30,7 @@ it("profile should return a valid updated profile (version increased)", async ()
     is_email_enabled: true,
     is_webhook_enabled: true,
     email: "[email protected]" as EmailAddress,
-    version: 5
+    version: 1
   };
   const response = await request
     .post(`${basePath}/profile`)