Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview #6779

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+11 −8
Open

chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview #6779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe5e8d2
chore: a11y improvements on payment method details card preview
Hantex9 Mar 4, 2025
1f6fea6
Merge branch 'master' into IOBP-1243-a11y-payment-method-details
LeleDallas Mar 6, 2025
b4a916f
Merge branch 'master' into IOBP-1243-a11y-payment-method-details
LeleDallas Mar 6, 2025
2e94147
Merge branch 'master' into IOBP-1243-a11y-payment-method-details
Hantex9 Mar 6, 2025
34f46b6
fix: Disable heading label to be focusable and add a wrapper accessib…
Hantex9 Mar 6, 2025
de7a955
Merge branch 'master' into IOBP-1243-a11y-payment-method-details
Hantex9 Mar 6, 2025
75e4dc2
Merge remote-tracking branch 'origin/IOBP-1243-a11y-payment-method-de…
Hantex9 Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ts/features/payments/common/components/PaymentCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,13 @@ const PaymentCard = (props: PaymentCardComponentProps) => {
const renderBankLogo = () => {
if (props.holderEmail) {
return (
<PayPalLogo
testID="paymentCardPayPalLogoTestId"
accessible={true}
accessibilityLabel="PayPal"
height={48}
width={113}
/>
<View accessibilityLabel="PayPal">
<PayPalLogo
testID="paymentCardPayPalLogoTestId"
height={48}
width={113}
/>
</View>
);
}

Expand Down
5 changes: 4 additions & 1 deletion ts/features/payments/details/components/PaymentsMethodDetailsBaseScreenComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ const PaymentsMethodDetailsBaseScreenComponent = ({
scrollEventThrottle={8}
snapToOffsets={[0, titleHeight]}
snapToEnd={false}
importantForAccessibility="no"
contentContainerStyle={{
flexGrow: 1,
paddingBottom: 48,
Expand All @@ -104,7 +105,9 @@ const PaymentsMethodDetailsBaseScreenComponent = ({
/>
<View style={[styles.blueHeader, { backgroundColor: blueHeaderColor }]}>
<View style={styles.cardContainer} onLayout={getTitleHeight}>
<PaymentCard {...card} />
<View accessible accessibilityRole="summary">
<PaymentCard {...card} />
</View>
</View>
</View>
<VSpacer size={24} />
Expand Down
Loading