Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview #6779

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Mar 4, 2025

Short description

This PR improves the a11y behavior from the payment method detail screen by adding a more detailed summary label when focusing on the payment method card.

List of changes proposed in this pull request

  • Wrapped the PayPalLogo component inside a View from the PaymentCard component to be accessible with a description;
  • Added the accessibilityRole to the view that wraps the payment card detail from the Payment method details;

How to test

  • With the SR enabled, navigate the payment method details screen and check that PayPal is announced correctly when focusing on the payment card and that Validity is announced correctly if the payment is a card.

@Hantex9 Hantex9 added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Mar 4, 2025
@Hantex9 Hantex9 requested review from ChrisMattew, gispada, freddi301 and a team as code owners March 4, 2025 10:09
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 4, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@Hantex9 Hantex9 changed the title chore: [IOBP-1243,IOBP-1244] a11y improvements on payment method details card preview chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.44%. Comparing base (5a91614) to head (2e94147).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5a91614) and HEAD (2e94147). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (5a91614) HEAD (2e94147)
10 3
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6779       +/-   ##
===========================================
- Coverage   50.94%   36.44%   -14.50%     
===========================================
  Files        1578     1402      -176     
  Lines       32708    29783     -2925     
  Branches     7374     6659      -715     
===========================================
- Hits        16663    10855     -5808     
- Misses      15998    18903     +2905     
+ Partials       47       25       -22     
Files with missing lines Coverage Δ
...eatures/payments/common/components/PaymentCard.tsx 96.87% <ø> (ø)
...nents/PaymentsMethodDetailsBaseScreenComponent.tsx 13.63% <ø> (ø)

... and 567 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a91614...2e94147. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Android, I was unable to focus on the validity label by swiping/tapping

Screen.Recording.2025-03-06.at.08.47.54.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants