-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-2687] Offline wallet: no internet connection scenario #6767
base: master
Are you sure you want to change the base?
Conversation
…sses the app and is redirected to the offline wallet
…to use the offline wallet
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6767 +/- ##
==========================================
+ Coverage 46.40% 50.97% +4.57%
==========================================
Files 1453 1580 +127
Lines 30546 32717 +2171
Branches 6913 7363 +450
==========================================
+ Hits 14176 16679 +2503
+ Misses 16320 15991 -329
+ Partials 50 47 -3
... and 322 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…removed an unhelpful comment
Short description
This PR implements the logic that allows users to access the offline version of the wallet when there is no internet connection.
List of changes proposed in this pull request
isConnectedSelector
provided by the platform, ensuring a more consistent and standardized approach.offlineAccessReason
, two actionsetOfflineAccessReason
andresetOfflineAccessReason
, and a selectorofflineAccessReasonSelector
to track the reason why a user is accessing the offline wallet. All three cases have been mapped:ts/features/itwallet/wallet/utils/withOfflineAlert.tsx
Demo
with_wi.mov
no_wi.mov
no_FF.mov
back_online_flow.mov
How to test
Warning
Currently, there is no way to perform dev mode testing of the offline scenario on iOS device (either physical or emulator) so I suggest using a physical Android device
Settings > Documents on IO > Enable offline access
itwLifecycleIsOperationalOrValid
:true
if you need an active wallet instance.false
if you want to test the flow without a wallet instance.If the wallet instance is active and the feature flag is enabled, you should be redirected to the offline flow.
Otherwise, you should see the default ("as-is") screen.