-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-2072] Ensure ITW is ready when app enters offline mode #6778
base: master
Are you sure you want to change the base?
Conversation
…sses the app and is redirected to the offline wallet
…to use the offline wallet
…removed an unhelpful comment
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iPhone 13 mini. When offline the bundler was not connected but everything looks ok, I still have my MDL. Tried a reload with connection and everything was working normally. Will test also #6782 when ready!
LGTM
Warning
Depends on #6767
Short description
This PR ensures that all ITW data is available when app enters offline mode.
Demo
Registrazione.schermo.2025-03-05.alle.11.22.27.mov
List of changes proposed in this pull request
handleWalletCredentialsRehydration
before any network call inside theinitializeApplicationSaga
shouldRenderItwCardsContainerSelector
now returns true if the remote FF is turned off but the app is offlinewithItwEnabled
HOC now renders the screen if the remote FF is turned off but the app is offlineHow to test
Go to Settings → Documenti su IO → Enable offline access .
With the app online → check if there aren't regressions
With the app offline → with a valid Wallet Instance, check if you are able to see your wallet with all the credentials.