Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-866] Display tags in the header of a SEND message #5440

Merged
merged 18 commits into from
Jan 30, 2024

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented Jan 25, 2024

This PR depends on #5431

Short description

This PR updates the MessageDetails component in order to display the tags.

NOTE: Other PRs will follow to update the rest of the message.

Details

MessageDetails

List of changes proposed in this pull request

  • added the tags in the header of the SEND message

How to test

Using the io-dev-api-server, generate a SEND message. Enable the design system and navigate to the message details. Check that the content is displayed correctly.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-866] Display tags in the header of a SEND message feat: [IOCOM-866] Display tags in the header of a SEND message Jan 25, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 25, 2024

Affected stories

  • 🌟 IOCOM-866: [App] Adattare tag con iconcina
    subtask of
    • IOCOM-814: Adottare il nuovo design system nel dettaglio di un messaggio di SEND

Generated by 🚫 dangerJS against 5e1eb41

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (52a3d1e) 47.29% compared to head (2207604) 47.31%.

❗ Current head 2207604 differs from pull request most recent head 5e1eb41. Consider uploading reports for the commit 5e1eb41 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5440      +/-   ##
==========================================
+ Coverage   47.29%   47.31%   +0.02%     
==========================================
  Files        1463     1463              
  Lines       31368    31374       +6     
  Branches     7628     7630       +2     
==========================================
+ Hits        14835    14846      +11     
+ Misses      16475    16470       -5     
  Partials       58       58              
Files Coverage Δ
ts/features/pn/components/MessageDetails.tsx 87.50% <87.50%> (-12.50%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a3d1e...5e1eb41. Read the comment docs.

Copy link

dpulls bot commented Jan 29, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste merged commit d51761c into master Jan 30, 2024
6 checks passed
@adelloste adelloste deleted the IOCOM-866-tags branch January 30, 2024 11:35
adelloste added a commit that referenced this pull request Feb 2, 2024
This PR depends on #5440

## Short description
This PR adds service header in `MessageDetailsScreen`.

<details open><summary>Details</summary>
<p>

| MessageDetails |
| - |
| <img
src="https://github.com/pagopa/io-app/assets/29163287/d90c4f3c-129c-453d-9396-41231343312a"
width="300"/> |

</p>
</details> 

## List of changes proposed in this pull request
- added `OrganizationHeader`
- updated `MessageDetailHeader` to display the `OrganizationHeader`
component
- updated tests

## How to test
Using the `io-dev-api-server`, generate a SEND message. Enable the
design system and navigate to the message details. Check that the
content is displayed correctly.

---------

Co-authored-by: Andrea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants