Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-867] Add service info in MessageDetailsScreen #5461

Merged
merged 29 commits into from
Feb 2, 2024

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented Jan 30, 2024

This PR depends on #5440

Short description

This PR adds service header in MessageDetailsScreen.

Details

MessageDetails

List of changes proposed in this pull request

  • added OrganizationHeader
  • updated MessageDetailHeader to display the OrganizationHeader component
  • updated tests

How to test

Using the io-dev-api-server, generate a SEND message. Enable the design system and navigate to the message details. Check that the content is displayed correctly.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-867] Add service info in MessageDetailsScreen feat: [IOCOM-867] Add service info in MessageDetailsScreen Jan 30, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 30, 2024

Affected stories

  • 🌟 IOCOM-867: [App] Adattare header servizio
    subtask of
    • IOCOM-814: Adottare il nuovo design system nel dettaglio di un messaggio di SEND

Generated by 🚫 dangerJS against b725c7f

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2817ce2) 47.91% compared to head (b725c7f) 47.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5461      +/-   ##
==========================================
+ Coverage   47.91%   47.92%   +0.01%     
==========================================
  Files        1398     1399       +1     
  Lines       30182    30188       +6     
  Branches     7388     7390       +2     
==========================================
+ Hits        14462    14468       +6     
  Misses      15651    15651              
  Partials       69       69              
Files Coverage Δ
...s/components/MessageDetail/MessageDetailHeader.tsx 100.00% <100.00%> (ø)
...es/components/MessageDetail/OrganizationHeader.tsx 100.00% <100.00%> (ø)
ts/features/pn/screens/MessageDetailsScreen.tsx 82.85% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2817ce2...b725c7f. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste merged commit b2ea541 into master Feb 2, 2024
8 checks passed
@adelloste adelloste deleted the IOCOM-867-org-header branch February 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants