chore: [IOBP-489] Removal of BPD references around the app #5421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
mastro993
added
Bonus Pagamenti Digitali
IO-Bonus e pagamenti
…ione-riferimenti-a-bonus-cashback-da-flussi-in-app
…cashback-da-flussi-in-app
…lussi-in-app' of https://github.com/pagopa/io-app into IOBP-489-fe-rimozione-riferimenti-a-bonus-cashback-da-flussi-in-app
…cashback-da-flussi-in-app
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5421 +/- ##
==========================================
- Coverage 47.42% 47.32% -0.11%
==========================================
Files 1604 1508 -96
Lines 33645 32007 -1638
Branches 8219 7832 -387
==========================================
- Hits 15956 15147 -809
+ Misses 17631 16802 -829
Partials 58 58
... and 115 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…cashback-da-flussi-in-app
…cashback-da-flussi-in-app
mastro993
reviewed
Jan 24, 2024
ts/screens/wallet/payment/__tests__/TransactionErrorScreen.test.tsx
Outdated
Show resolved
Hide resolved
…cashback-da-flussi-in-app
…cashback-da-flussi-in-app
forrest57
deleted the
IOBP-489-fe-rimozione-riferimenti-a-bonus-cashback-da-flussi-in-app
branch
forrest57
added a commit
that referenced
this pull request
Jan 29, 2024
## Short description removal of the whole BPD folder, along with some weird references here and there DEPENDS ON #5421 ## List of changes proposed in this pull request - removed the *whole* folder - removed feature flags in the env files - removed references to BPD around the app the api definitions for the whole bonus section will be removed in a future PR ## How to test same as last PR, take a stroll around the app and make sure nothing breaks; theoretically *the user* should not notice any difference. stay on the lookout especially in: - cgn onboarding - payment method onboarding - payment flow - messages - idpay flows --------- Co-authored-by: Federico Mastrini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
first big step to remove BPD and/or cashback from the app
List of changes proposed in this pull request
How to test
have a stroll through the app, testing the various flows.
The ones you should be most on the look for should be: