Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-490] Removal of BPD folder #5432

Merged
merged 12 commits into from
Jan 29, 2024
Merged

Conversation

forrest57
Copy link
Contributor

@forrest57 forrest57 commented Jan 24, 2024

Short description

removal of the whole BPD folder, along with some weird references here and there

DEPENDS ON #5421

List of changes proposed in this pull request

  • removed the whole folder
  • removed feature flags in the env files
  • removed references to BPD around the app

the api definitions for the whole bonus section will be removed in a future PR

How to test

same as last PR, take a stroll around the app and make sure nothing breaks; theoretically the user should not notice any difference.
stay on the lookout especially in:

  • cgn onboarding
  • payment method onboarding
  • payment flow
  • messages
  • idpay flows

@forrest57 forrest57 requested review from dmnplb and a team as code owners January 24, 2024 11:59
@pagopa-github-bot pagopa-github-bot changed the title [IOBP-490] removal of BPD folder chore: [IOBP-490] Removal of BPD folder Jan 24, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 24, 2024

Affected stories

  • ⚙️ IOBP-490: [FE] Rimozione codice legacy relativo a Bonus Cashback
    subtask of
    • ⚙️ IOBP-75: Rimozione Cashback

Generated by 🚫 dangerJS against ce9cd48

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (18f8cb3) 47.35% compared to head (ce9cd48) 47.12%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5432      +/-   ##
==========================================
- Coverage   47.35%   47.12%   -0.23%     
==========================================
  Files        1512     1459      -53     
  Lines       32166    31315     -851     
  Branches     7860     7621     -239     
==========================================
- Hits        15231    14757     -474     
+ Misses      16876    16500     -376     
+ Partials       59       58       -1     
Files Coverage Δ
...s/features/bonus/cgn/store/reducers/unsubscribe.ts 37.50% <ø> (ø)
...tures/bonus/common/components/DeclarationEntry.tsx 30.00% <ø> (ø)
...s/features/bonus/common/components/ProgressBar.tsx 50.00% <ø> (ø)
...ures/bonus/common/screens/AvailableBonusScreen.tsx 7.40% <ø> (+0.13%) ⬆️
ts/features/bonus/common/store/reducers/index.ts 100.00% <ø> (ø)
...voucherGeneration/DisabledAdditionalInfoScreen.tsx 28.57% <ø> (ø)
...features/design-system/core/DSLegacyPictograms.tsx 50.00% <ø> (ø)
...arcode/components/BarcodeExpirationProgressBar.tsx 13.33% <ø> (ø)
...res/wallet/component/card/FeaturedCardCarousel.tsx 35.18% <ø> (+0.63%) ⬆️
...wallet/onboarding/bancomatPay/navigation/action.ts 50.00% <ø> (ø)
... and 26 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7da49...ce9cd48. Read the comment docs.

@mastro993 mastro993 added Bonus Pagamenti Digitali IO-Bonus e pagamenti IO - Bonus e pagamenti 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed labels Jan 24, 2024
Copy link

dpulls bot commented Jan 26, 2024

🎉 All dependencies have been resolved !

@forrest57 forrest57 merged commit f47f87a into master Jan 29, 2024
8 checks passed
@forrest57 forrest57 deleted the IOBP-490-bpd-folder-removal branch January 29, 2024 09:11
forrest57 added a commit that referenced this pull request Jan 31, 2024
## Short description
thorough cleanup after the removal of BPD and BV,
DEPENDS ON #5432

## List of changes proposed in this pull request
- removed scripts
- updated config files
- updated env files
- removed i18n entries
- removed mocks where possible
- removed now completely useless client and actions
- removed now useless saga

## How to test
as usual, run the tests and have a look around the app, nothing should
break or change from an user's perspective

---------

Co-authored-by: Federico Mastrini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bonus Pagamenti Digitali 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants