chore: [IOPID-1298,IOPID-1396] Main stack navigator - startup saga synch
#5420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
shadowsheep1
changed the title
Main stack navigator - startup saga synch
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5420 +/- ##
==========================================
- Coverage 47.48% 47.46% -0.03%
==========================================
Files 1604 1604
Lines 33577 33600 +23
Branches 8197 8204 +7
==========================================
+ Hits 15944 15948 +4
- Misses 17575 17594 +19
Partials 58 58
Continue to review full report in Codecov by Sentry.
|
shadowsheep1
added
legal-approved ⚖️ ✅
Vangaorth
added a commit
that referenced
this pull request
Jan 24, 2024
…#5429) This PR depends on #5420 ## Short description This PR fixes the E2E tests, following changes from the stack navigator and startup saga sync. ## List of changes proposed in this pull request - reloadReactNative replaced with launchApp({ newInstance: true}) to prevent bad behaviours - improved a credit card test by searching for a testId instead of a text - better system keyboard closing ## How to test Run the E2E tests. --------- Co-authored-by: Fabio Bombardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR tries to synchronize the Main stack navigator with the startup saga business logic.
List of changes proposed in this pull request
It uses the
waitForMainNavigatorgenerator function that acts likewaitForNavigatorServiceInitialization.How to test