Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix E2E tests after main stack navigator and startup saga sync #5429

Merged
merged 9 commits into from
Jan 24, 2024

Conversation

Vangaorth
Copy link
Contributor

This PR depends on #5420

Short description

This PR fixes the E2E tests, following changes from the stack navigator and startup saga sync.

List of changes proposed in this pull request

  • reloadReactNative replaced with launchApp({ newInstance: true}) to prevent bad behaviours
  • improved a credit card test by searching for a testId instead of a text
  • better system keyboard closing

How to test

Run the E2E tests.

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 23, 2024

Warnings
⚠️ Please include a Pivotal story or Jira ticket at the beginning of the PR title

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against cbd9fba

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3e0f184) 47.44% compared to head (cbd9fba) 47.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5429      +/-   ##
==========================================
- Coverage   47.44%   47.44%   -0.01%     
==========================================
  Files        1604     1603       -1     
  Lines       33613    33611       -2     
  Branches     8205     8204       -1     
==========================================
- Hits        15949    15948       -1     
+ Misses      17606    17605       -1     
  Partials       58       58              
Files Coverage Δ
ts/components/wallet/WalletHomeHeader.tsx 17.64% <ø> (ø)
...res/bonus/cgn/components/detail/CgnUnsubscribe.tsx 6.25% <0.00%> (+0.36%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0f184...cbd9fba. Read the comment docs.

@Vangaorth Vangaorth marked this pull request as ready for review January 24, 2024 07:52
@Vangaorth Vangaorth requested a review from a team as a code owner January 24, 2024 07:52
Copy link

dpulls bot commented Jan 24, 2024

🎉 All dependencies have been resolved !

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth merged commit d34be63 into master Jan 24, 2024
8 checks passed
@Vangaorth Vangaorth deleted the fix/e2eTests branch January 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants