-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-1391] Fix tablet compatibility alert displaying #5417
feat: [IOPID-1391] Fix tablet compatibility alert displaying #5417
Conversation
Affected stories
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5417 +/- ##
==========================================
- Coverage 47.48% 47.48% -0.01%
==========================================
Files 1604 1604
Lines 33578 33577 -1
Branches 8199 8197 -2
==========================================
- Hits 15945 15944 -1
Misses 17575 17575
Partials 58 58
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR fixes the continuously displaying of the Tablet compatibility alert during the login flow. It took the chance to refactor the
LandingScreen
fromPureComponent
toFunctionComponent
.Details
default.mov
default.mov
How to test
Launch the app on an Android Tablet and check that the Alert is shown only at every first render of
LandingScreen
.