Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-1391] Fix tablet compatibility alert displaying #5417

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Jan 22, 2024

Short description

This PR fixes the continuously displaying of the Tablet compatibility alert during the login flow. It took the chance to refactor the LandingScreen from PureComponent to FunctionComponent.

Details

default.mov
default.mov

How to test

Launch the app on an Android Tablet and check that the Alert is shown only at every first render of LandingScreen.

@pagopa-github-bot pagopa-github-bot changed the title [IOPID-1391] Fix tablet compatibility alert displaying feat: [IOPID-1391] Fix tablet compatibility alert displaying Jan 22, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 22, 2024

Affected stories

  • 🌟 IOPID-1391: Visualizzazione banner incompatibilità su Tablet
    subtask of

Generated by 🚫 dangerJS against c016220

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (46af866) 47.48% compared to head (c016220) 47.48%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5417      +/-   ##
==========================================
- Coverage   47.48%   47.48%   -0.01%     
==========================================
  Files        1604     1604              
  Lines       33578    33577       -1     
  Branches     8199     8197       -2     
==========================================
- Hits        15945    15944       -1     
  Misses      17575    17575              
  Partials       58       58              
Files Coverage Δ
ts/navigation/AuthenticationNavigator.tsx 66.66% <ø> (ø)
ts/screens/authentication/LandingScreen.tsx 3.93% <1.23%> (-0.76%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46af866...c016220. Read the comment docs.

@shadowsheep1 shadowsheep1 marked this pull request as ready for review January 22, 2024 13:20
@shadowsheep1 shadowsheep1 requested a review from a team as a code owner January 22, 2024 13:20
@shadowsheep1 shadowsheep1 self-assigned this Jan 22, 2024
@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label Jan 22, 2024
Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowsheep1 shadowsheep1 merged commit 9fc529f into master Jan 23, 2024
7 checks passed
@shadowsheep1 shadowsheep1 deleted the IOPID-1391-fix-tablet-compatibility-alert branch January 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants