Skip to content

Commit

Permalink
feat: [IOPID-1391] Fix tablet compatibility alert displaying (#5417)
Browse files Browse the repository at this point in the history
## Short description
This PR fixes the continuously displaying of the Tablet compatibility
alert during the login flow. It took the chance to refactor the
`LandingScreen` from `PureComponent` to `FunctionComponent`.

<details open><summary>Details</summary>
<p>

| ❌ | ✅ |
| - | - |
| <video
src="https://github.com/pagopa/io-app/assets/16268789/68836f13-88f9-41a5-98a6-eceea56de750"
/> | <video
src="https://github.com/pagopa/io-app/assets/16268789/0e6e24ff-31a2-4aef-958e-0402564629e6"
/> |

</p>

</details> 

## How to test
Launch the app on an Android Tablet and check that the Alert is shown
only at every first render of `LandingScreen`.
  • Loading branch information
shadowsheep1 authored Jan 23, 2024
1 parent 46af866 commit 9fc529f
Show file tree
Hide file tree
Showing 2 changed files with 158 additions and 164 deletions.
2 changes: 1 addition & 1 deletion ts/navigation/AuthenticationNavigator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import CiePinScreen from "../screens/authentication/cie/CiePinScreen";
import CieWrongCiePinScreen from "../screens/authentication/cie/CieWrongCiePinScreen";
import IdpLoginScreen from "../screens/authentication/IdpLoginScreen";
import IdpSelectionScreen from "../screens/authentication/IdpSelectionScreen";
import LandingScreen from "../screens/authentication/LandingScreen";
import { LandingScreen } from "../screens/authentication/LandingScreen";
import TestAuthenticationScreen from "../screens/authentication/TestAuthenticationScreen";
import MarkdownScreen from "../screens/development/MarkdownScreen";
import { AuthSessionPage } from "../screens/authentication/idpAuthSessionHandler";
Expand Down
Loading

0 comments on commit 9fc529f

Please sign in to comment.