-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOBP-1243,IOBP-1244,IOBP-1241] a11y improvements on payment method details card preview #6779
base: master
Are you sure you want to change the base?
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6779 +/- ##
==========================================
+ Coverage 46.40% 50.97% +4.56%
==========================================
Files 1453 1578 +125
Lines 30546 32688 +2142
Branches 6913 7358 +445
==========================================
+ Hits 14176 16663 +2487
+ Misses 16320 15978 -342
+ Partials 50 47 -3
... and 323 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Short description
This PR improves the
a11y
behavior from the payment method detail screen by adding a more detailed summary label when focusing on the payment method card.List of changes proposed in this pull request
PayPalLogo
component inside aView
from thePaymentCard
component to be accessible with a description;accessibilityRole
to the view that wraps the payment card detail from the Payment method details;How to test
PayPal
is announced correctly when focusing on the payment card and thatValidity
is announced correctly if the payment is a card.