-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): migrate everything to ESM-only (japa
version)
#747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tap is a bit of a mess right now and its time to cut losses
Currently blocked on japa/runner#41 – the test is failing on Windows without an error trace. I might have to move back to |
paambaati
changed the title
feat(core): migrate everything to ESM-only
feat(core): migrate everything to ESM-only (Jun 6, 2024
japa
version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that GitHub Actions support Node 20, and Node 20 is LTS at least until October 2024, it is time we prepare for an ESM-only version of this action.
Currently blocked on tapjs/tapjs#976I've migrated tojapa
– it is much more stable, does everything I need, the API is very thoughtfully designed & a pleasure to use, and seems to be slightly faster thantap
– see c909795.