Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): migrate everything to ESM-only enhancement (tap version) #753

Merged
merged 31 commits into from
Jun 12, 2024
Merged

feat(core): migrate everything to ESM-only enhancement (tap version) #753

merged 31 commits into from
Jun 12, 2024

Conversation

paambaati
Copy link
Owner

Copy of #747 but with tap instead of japa.

paambaati and others added 21 commits April 26, 2024 13:46
@paambaati
feat(core): migrate everything to ESM-only
6e2b10b
@paambaati
chore(ci): remove dependabot ignores for CJS-only versions
98bdcc2
@paambaati
chore(core): better refactoring so Biome and TS strict mode don't clash
8575165
@paambaati
Merge branch 'main' into gp/esm-migration
0f53ba1
@paambaati
chore: upgrade dependencies
d6a8fe1
@paambaati
fix(tests): add back missing import
9eb6690
@paambaati
fix(test): use the @tapjs/tsx import loader to fix TS issues
295386a
@paambaati
fix(ci): use Node 22.x so the import loader will work as expected
d56acf0
@paambaati
chore: exclude coverage
5f5e60f
@paambaati
fix: upgrade tap to fix the plugin issues
f97429e 
See tapjs/tapjs#976 (comment)
@paambaati
chore: remove tap hacks
c75f50c
@paambaati
chore: convert run() args to destructured to make life easier
992e3e7
@paambaati
chore: upgrade pnpm
9903f40
@paambaati
feat(core/internal): migrate to Japa as test runner.
c909795 
tap is a bit of a mess right now and its time to cut losses
@paambaati
chore: debug failing test on Windows
4764b8b
@paambaati
chore: revert 4764b8b
5f0d00a
@paambaati
chore: routine dep upgrades
6e4b7d9
@paambaati
chore: upgrade deps
80e87d3
@paambaati
fix(test): try fixing tests on Windows (maybe)
47793be
@paambaati
fix: revert 47793be
e512c4b
@paambaati
fix: go back to tap because japa doesn't seem active
19034a0 
See japa/runner#41
@paambaati paambaati added the enhancement New feature or request label Jun 6, 2024
@paambaati paambaati self-assigned this Jun 6, 2024
@paambaati paambaati mentioned this pull request Jun 6, 2024
Closed
3 tasks
@paambaati
Copy link
Owner Author

paambaati commented Jun 6, 2024 •
edited
Loading

All tests are green but currently blocked on 2 1 issue –

  1. 🐛 biome ci passes locally on macOS but fails on Linux on CI (GHA) biomejs/biome#3087
  2. [BUG] Tests fully broken on local macOS in latest version (19.2.1) tapjs/tapjs#1030 – waiting on fix: escape executable file path for shell tapjs/tapjs#1032 to land.

@ematipico ematipico mentioned this pull request Jun 6, 2024
Closed
1 task
@paambaati paambaati mentioned this pull request Jun 10, 2024
Closed
@paambaati paambaati mentioned this pull request Jun 11, 2024
Closed
@paambaati
Copy link
Owner Author

Waiting on tapjs/tapjs#1032 to land.

@paambaati paambaati merged commit fed36ec into main Jun 12, 2024
5 checks passed
@paambaati paambaati deleted the gp/esm-migration-tap branch June 12, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paambaati paambaati

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paambaati