Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive import #34

Merged
merged 89 commits into from
Oct 4, 2024
Merged

Interactive import #34

merged 89 commits into from
Oct 4, 2024

Commits on Aug 4, 2024

  1. Configuration menu
    Copy the full SHA
    f1e3ff8 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. more explorations

    pSpitzner committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3782cc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    1fc1707 View commit details
    Browse the repository at this point in the history
  2. updated some comments

    pSpitzner committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    02ed033 View commit details
    Browse the repository at this point in the history
  3. emitting from worker to frontend works, also sending candidate selection

    added a bunch of typing for beets AlbumInfo, TrackInfo and managed (poorly) to serialize them.
    pSpitzner committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a98abd2 View commit details
    Browse the repository at this point in the history
  4. reconnecting to existing session will likely require async. for now s…

    …tarting new session.
    
    added types to frontend. candidates and prompts communication works, with some rough edges.
    pSpitzner committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4fcde0a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. parallel gui selections!

    pSpitzner committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d9147cd View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Configuration menu
    Copy the full SHA
    64f13a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a553ce8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c01177d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5de6a95 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b06b958 View commit details
    Browse the repository at this point in the history
  6. added penalty icons

    pSpitzner committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    6c910b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    18f7ea2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba3852a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. reordered penalty icons

    pSpitzner committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    18d3702 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c84b50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c0998d View commit details
    Browse the repository at this point in the history
  4. added trackchanges heading.

    pSpitzner committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    10feb23 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    421e71f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e997cd4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    da6eeaa View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a93c0e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Configuration menu
    Copy the full SHA
    68460c9 View commit details
    Browse the repository at this point in the history
  2. Renamed import to importer because it is a reserved keyword. Also moved

    the websocket routes into their own folder (Terminal and Importer).
    
    Added a text input to define the path of the import, for debugging.
    
    No output in frontend thus far, but connection and init seems to work.
    semohr committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    cd16cbf View commit details
    Browse the repository at this point in the history
  3. Socket export seem to work after using namespaces correctly.

    Frontend still broken
    semohr committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    e070865 View commit details
    Browse the repository at this point in the history
  4. Back-end is working now and communication of states is working!

    Front-end needs fixing according to new types tho. Also status updates
    are not reimplemented yet.
    semohr committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    08a9ebf View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Configuration menu
    Copy the full SHA
    343c469 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b99cba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df36128 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    498cf98 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7588db8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    74814be View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. apply button now works, but we need to think about how to abort and u…

    …nmounting after we are done.
    pSpitzner committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ecf870c View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Streamlined the import candidate details:

    Moved the files for candidate formatting into its own folder
    and removed some unnecessary css declarations.
    
    Enhanced the grid layout of the trackChanges class
    for proper number alignment.
    
    Adjusted font sizes for trackChanges to overall fit more content.
    
    Added a temporary component to view the current candidate changes.
    semohr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7977426 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    edefc15 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    16af9d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    172f2bf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f5d4d63 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    15f6704 View commit details
    Browse the repository at this point in the history
  5. new album folder logic looking good. is_album_folder is slower but …

    …now checks
    
    multidisc consistent with beets. `all_album_folders` (used by inbox!) is some 20% faster
    but still ~75 sec to scan ~250gb of muisc folders via lan from spinning discs.
    we still need to handle this better - large inboxes are still not doable.
    pSpitzner committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    d930d83 View commit details
    Browse the repository at this point in the history
  6. updated dict structure generator for multi-disc albums, and to use os…

    ….walk.
    
    some 10% faster than glob. also sessions should now work on multi-disk albums.
    pSpitzner committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f0ff3c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. updated changelog

    pSpitzner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d62b81c View commit details
    Browse the repository at this point in the history
  2. working duplicate detection on candidate level. beets config needs to…

    … have `import/duplicates = ask`
    
    showing duplicates works, todo: handle them and tidy up.
    pSpitzner committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    683be8f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. dealing with duplicates, also limited number of candidates to show to…

    … 5...
    
    I attached the duplicate action to the selection state (instead of candidate).
    Also was lazy and re-used the existing socket-event (candidatechoice).
    we should probably tidy this up a bit more. but it seems to work.
    pSpitzner committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    afb32f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. converted candidate state identifier from index to uuid. also new con…

    …vention:
    
    for dataclasses, define all attributes with default values (that should not be set)
    in the __post__ init, so it remains easy to see whats needed for the constructor,
    since we do not code an __init__ function.
    pSpitzner committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    5039acd View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    7005b05 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. handling asis option and disabled apply button when no duplicate acti…

    …on selected
    
    (todo: check that default duplicate action from config works)
    pSpitzner committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    953049a View commit details
    Browse the repository at this point in the history
  2. simplified asis logic - need no attribute, just reuse/abuse the id. a…

    …lso added badge,
    
    and reordered the display. badge needs better styling: fix height and width
    and maybe create some character padding / centering.
    pSpitzner committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f86ee04 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    a42549a View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Modal for adding candidates, and implemented search by artist + album.

    Not quite there yet but feels like a good point to do another high-level planning session before finalizing
    pSpitzner committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    22eb23a View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    2e56dcd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93fcd9e View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Wait for search on backend.

    semohr committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2887cb8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9330f41 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    62bc3b7 View commit details
    Browse the repository at this point in the history
  2. Added a small component to select a folder from the inboxes as I was …

    …a bit
    
    annoyed by typing the path again and again...
    
    I had to update mui for this as I wanted to use autocomplete. Hope this
    produces no issues.
    semohr committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8f6948a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55bb4c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2fcf60 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    a383b20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e60e367 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Configuration menu
    Copy the full SHA
    697c8ff View commit details
    Browse the repository at this point in the history
  2. Mainly import cleanup:

    - Added abort session ws endpoint
    - added more details to status messages, fully typed now
    - added abort button in frontend depending on current state
    - fixed issues with initial state set by clients, this produces a deadlock
     if multiple clients are connected and all want to reset the candidate
    semohr committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d61dae4 View commit details
    Browse the repository at this point in the history
  3. Import page styling overhaul, not perfect but I like it way more.

    WIP: Apply button still needs some work i.e. it is broken atm and does
    not work, also styling of the apply btn is not too nice.
    semohr committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    733be70 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. added charwdith argument to similarity badge to allow consistent hori…

    …zontal alignement with 'asis'
    pSpitzner committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    dad620e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb4f795 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    a5ddc05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e913860 View commit details
    Browse the repository at this point in the history
  3. (A bit more) graceful handling of session ends. Added abort state to …

    …status
    
    but then realized we likely dont need it yet.
    Layout should be more streamlined for the (common) case that we only import one selection.
    I'd group all buttons at the end (check length of the selectionstates
    to either place apply+abort outside, or inline with duplicate and search)
    pSpitzner committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f358040 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a1ef41 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. BottomBar for import. Needs work, but need to look at whole body beha…

    …viour together.
    
    (currently scroll only takes place on inner container, which looks weird.
    i think we need a helper css to get limited-width for wide windows to avoid the nested containers!)
    pSpitzner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e651850 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    407158a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Moved to terminal route

    semohr committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0d46022 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. @sm the terminal import context menu actions are broken, since the te…

    …rminalcontext
    
    is not global anymore. any ideas for workarounds?
    pSpitzner committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7bfc2b0 View commit details
    Browse the repository at this point in the history
  2. added our own ContainerWidth class.

    Library-Search still needs work.
    And Search and Library List views seem a bit broken for me currently - no items showing.
    (sporadically)
    Maybe since MUI upgrade?
    pSpitzner committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2934435 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    360d2ff View commit details
    Browse the repository at this point in the history
  4. Fixed double click problem with routing from navbar. Was an issue in the

    useQueryParamsState hook.
    Updated tanstack to latest version.
    semohr committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e4c9a0a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9bc7f04 View commit details
    Browse the repository at this point in the history
  6. Added a indicator for asis.

    semohr committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e8d6d88 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    670beb8 View commit details
    Browse the repository at this point in the history
  8. Added autoimport icon, this required me to add a vite svg handler, which

    auto parses svgs as react components.
    semohr committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1918237 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Removed dependency on flask_rq2, should work now without it only using

    rq. Needs some more testing tho.
    semohr committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1bfe1dc View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Intersection observer working

    semohr committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    372e972 View commit details
    Browse the repository at this point in the history
  2. Fixed styling

    semohr committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    36a0857 View commit details
    Browse the repository at this point in the history
  3. Readded border styling

    semohr committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    df42a80 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eaedb01 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a2dfa7f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b8af08f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2f7e78a View commit details
    Browse the repository at this point in the history