Interactive import #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a bunch of typing for beets AlbumInfo, TrackInfo and managed (poorly) to serialize them.
…tarting new session. added types to frontend. candidates and prompts communication works, with some rough edges.
the websocket routes into their own folder (Terminal and Importer). Added a text input to define the path of the import, for debugging. No output in frontend thus far, but connection and init seems to work.
Frontend still broken
Front-end needs fixing according to new types tho. Also status updates are not reimplemented yet.
- Added abort session ws endpoint - added more details to status messages, fully typed now - added abort button in frontend depending on current state - fixed issues with initial state set by clients, this produces a deadlock if multiple clients are connected and all want to reset the candidate
WIP: Apply button still needs some work i.e. it is broken atm and does not work, also styling of the apply btn is not too nice.
…zontal alignement with 'asis'
…status but then realized we likely dont need it yet. Layout should be more streamlined for the (common) case that we only import one selection. I'd group all buttons at the end (check length of the selectionstates to either place apply+abort outside, or inline with duplicate and search)
…viour together. (currently scroll only takes place on inner container, which looks weird. i think we need a helper css to get limited-width for wide windows to avoid the nested containers!)
…rminalcontext is not global anymore. any ideas for workarounds?
Library-Search still needs work. And Search and Library List views seem a bit broken for me currently - no items showing. (sporadically) Maybe since MUI upgrade?
useQueryParamsState hook. Updated tanstack to latest version.
auto parses svgs as react components.
rq. Needs some more testing tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an interactive import screen with rich html preview of candidates