Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useEffect to set editor.tsx#isEditable #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: useEffect to set editor.tsx#isEditable #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2f00a4
fix: useEffect to set editor.tsx#isEditable
ICEDLEE337 Jul 21, 2024
d6c87f0
fix: disable editing via popup when isEditable is false
ICEDLEE337 Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const Editor = ({
}: IEditorProps) => {
const [editor] = useLexicalComposerContext();
const [activeEditor, setActiveEditor] = useState(editor);

const [_isEditable, setIsEditable] = useState(isEditable);
const editorStateRef = useRef(null);
const { historyState } = useSharedHistoryContext();
const {
Expand All @@ -83,8 +83,10 @@ const Editor = ({
useEffect(() => {
editor.setEditable(isEditable);

setIsEditable(isEditable);

if (locale) i18n.changeLanguage(locale);
}, []);
}, [isEditable]);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without adding isEditable to the useEffect array, the editor doesn't respect changes to the Editor.tsx#isEditable property from external consumers.


return (
<EditorContext.Provider
Expand Down Expand Up @@ -121,7 +123,7 @@ const Editor = ({
<ListMaxIndentLevelPlugin maxDepth={listMaxIndent} />
<LinkPlugin />
<ClickableLinkPlugin />
<CharacterStylesPopupPlugin />
{_isEditable && <CharacterStylesPopupPlugin />}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The popup would appear and enable formatting changes even when disabled was set to false.

<TabFocusPlugin />
</>

Expand Down