fix: useEffect to set editor.tsx#isEditable #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICEDLEE337
commented
Jul 21, 2024
| @@ -121,7 +123,7 @@ const Editor = ({ | |||
| <ListMaxIndentLevelPlugin maxDepth={listMaxIndent} /> | |||
| <LinkPlugin /> | |||
| <ClickableLinkPlugin /> | |||
| <CharacterStylesPopupPlugin /> | |||
| {_isEditable && <CharacterStylesPopupPlugin />} | |||
There was a problem hiding this comment.
The popup would appear and enable formatting changes even when disabled was set to false.
ICEDLEE337
commented
Jul 21, 2024
| if (locale) i18n.changeLanguage(locale); | ||
| }, []); | ||
| }, [isEditable]); |
There was a problem hiding this comment.
Without adding isEditable to the useEffect array, the editor doesn't respect changes to the Editor.tsx#isEditable property from external consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior: Externally changing the value of isEditable doesn't trigger a re-render and editor remains in same state.
**New behavior ** Externally changing the value of isEditable triggers a re-render and editor responds appropriately.
Context For example, it may be desireable for consuming code to lock the editor until a "Checkout for editing" button is clicked upon which server-side state reflects the fact that a specific user is currently editing the content as a primitive way of preventing merge conflicts.