-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional endpoints for editing RFDs #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 186 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
97 | 1 | 88 | 0 |
Click to see the invalid file list
- rfd-data/src/content/template.rs
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Is it possible to inject the author automatically on the new RFD endpoint? Not sure if you have the user's name and email already? In general I think we could benefit from a |
Currently it doesn't link the author intentionally. While we do have the login email from the underlying oauth provider, we do not have a way for users to select which email is preferred. The plan is support all of this with a User information can be retrieved from |
Ok perfect, I'll give that a go. Does that information change depending on whether it's a GitHub or Google login? Does google provide a display name? |
We currently do not support a display name for Google logins, GitHub logins will list their username. You will get back a response something like this:
Currently users will have exactly one provider (either GitHub or Google), but that is soon to change. The other thing to be mindful of is that the |
Adds a number of endpoints for managing RFD contents and state:
/rfd/{number}
- Replace the full document of a RFD/rfd/{number}/content
- Replace the contents of a RFD/rfd/{number}/attr/{attr}
- Set an attribute of a RFD/rfd/{number}/discuss
- Open a RFD for discussion/rfd/{number}/publish
- Publish a RFD