Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RFD form modal #65

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

New RFD form modal #65

wants to merge 2 commits into from

Conversation

benjaminleonard
Copy link
Collaborator

@benjaminleonard benjaminleonard commented Sep 2, 2024

Uses new RFD post endpoint to create a new RFD. This endpoint may be successful, but it takes time to be both added to the GitHub repo and then scanned and collected by the database. To this end, this modal creates an RFD then polls to see if it has been created yet (see fetchWithRetry).

Currently it does not populate authors, waiting on an update to the endpoint to take authors and labels fields. The idea being it uses the authors email and name from the logged in user. The email returned from GitHub might not be an Oxide one, so we should attempt to find an Oxide email and if that can't be done it should just stay undefined.

image

  • Update User to store the array of emails returned from the auth provider
  • Find the first Oxide email in the logged in user's list of emails
  • Make title and author fields required
  • Add missing focus styles
  • Move text input component into the design system

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rfd-site ✅ Ready (Inspect) Visit Preview Sep 2, 2024 3:07pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant