Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): improve err handling when loading source text #8025

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(lsp): improve err handling when loading source text #8025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions crates/oxc_language_server/src/linter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,7 @@ impl IsolatedLintHandler {
debug!("extension not supported yet.");
return None;
}
let source_text = source_text.map_or_else(
|| fs::read_to_string(path).unwrap_or_else(|_| panic!("Failed to read {path:?}")),
|source_text| source_text,
);
let source_text = source_text.or_else(|| fs::read_to_string(path).ok())?;
let javascript_sources = match self.loader.load_str(path, &source_text) {
Ok(s) => s,
Err(e) => {
Expand Down
Loading