fix(lsp): improve err handling when loading source text

[camc314]

note i didn't test this, but it's panicing because fs::read_to_string is returning an error as the path no longer exists.

fixes #8023

[camc314]

• fix(lsp): improve err handling when loading source text #8025 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Sysix]

Thanks 👍
I am still asking myself why vscode has sent textDocument/didOpen. But this should be another problem ;)

[codspeed-hq]

CodSpeed Performance Report

Merging #8025 will not alter performance

_{Comparing c/12-19-fix_lsp_improve_err_handling_when_loading_source_text (6344b93) with main (0f9308f)}

Summary

✅ 29 untouched benchmarks

[camc314]

Thanks 👍 I am still asking myself why vscode has sent textDocument/didOpen. But this should be another problem ;)

i think the textDocument/didOpen that it sends is correct - it's just confusing for us to handle because it's opened a buffer that references a deleted file.

[camc314]

we should probably pass around DidOpenTextDocumentParams::text_document::TextDocumentItem::text and lint the actual text content of the doc rather than tryiing to read from disk, but that's a bigger lift that i think we should do in a different PR

[camc314]

[camc314]

Merge activity

• Dec 19, 2:07 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 19, 2:07 PM EST: A user added this pull request to the Graphite merge queue.
• Dec 19, 2:12 PM EST: A user merged this pull request with the Graphite merge queue.