Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): move no-unused-expressions from TS to eslint #7624

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 3, 2024

No description provided.

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Dec 3, 2024
@camc314 camc314 marked this pull request as ready for review December 3, 2024 21:54
@github-actions github-actions bot added the C-bug Category - Bug label Dec 3, 2024
Copy link
Contributor Author

camc314 commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/12-03-fix_linter_move_no-unused-expressions_from_ts_to_eslint branch from ffb0bac to fc66291 Compare December 3, 2024 21:57
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7624 will not alter performance

Comparing c/12-03-fix_linter_move_no-unused-expressions_from_ts_to_eslint (fcc2546) with main (29db060)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 requested a review from Boshen December 3, 2024 22:58
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
Copy link
Member

Boshen commented Dec 4, 2024

Merge activity

  • Dec 3, 8:59 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 8:59 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 3, 9:37 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/12-03-fix_linter_move_no-unused-expressions_from_ts_to_eslint branch from fc66291 to fcc2546 Compare December 4, 2024 02:26
@graphite-app graphite-app bot merged commit fcc2546 into main Dec 4, 2024
25 checks passed
@graphite-app graphite-app bot deleted the c/12-03-fix_linter_move_no-unused-expressions_from_ts_to_eslint branch December 4, 2024 02:37
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants