Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): detect typescript eslint alias rules #7622

Merged

Conversation

Sysix
Copy link
Contributor

@Sysix Sysix commented Dec 3, 2024

closes #7233

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Dec 3, 2024
@github-actions github-actions bot added the A-linter Area - Linter label Dec 3, 2024
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7622 will not alter performance

Comparing Sysix:fix-linter-detect-typescript-eslint-alias-rules (207a1df) with main (b4f3812)

Summary

✅ 29 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review December 3, 2024 18:56
@Sysix
Copy link
Contributor Author

Sysix commented Dec 3, 2024

I do not have a clue why the NAPI test are failing. I hope this is just a CI problem,
locally pnpm run build && pnpm run test works fine.

EDIT: foud some missing changes :'):
#7623

@Boshen Boshen merged commit 29db060 into oxc-project:main Dec 4, 2024
24 of 25 checks passed
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: no matching rules for some typescript rules
3 participants