Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/class-properties): move creating temp var out of main loop #7587

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 2, 2024

Small optimization. Move code out of the loop which determines if class property transform has nothing to do and can bail out early. This also clears the way for correcting the logic around when temp vars are/aren't created in #7516.

Copy link

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #7587 will not alter performance

Comparing 12-02-refactor_transformer_class-properties_move_creating_temp_var_out_of_main_loop (7bd6350) with 12-02-refactor_transformer_class-properties_exit_transform_class_faster_if_nothing_to_do (ebd11fb)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 12-02-refactor_transformer_class-properties_exit_transform_class_faster_if_nothing_to_do branch from 2d03bc9 to 594ad33 Compare December 3, 2024 01:59
@overlookmotel overlookmotel force-pushed the 12-02-refactor_transformer_class-properties_move_creating_temp_var_out_of_main_loop branch from 2e6be1b to 4a2961e Compare December 3, 2024 02:00
@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2024 02:23
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2024
Copy link

graphite-app bot commented Dec 3, 2024

Merge activity

… main loop (#7587)

Small optimization. Move code out of the loop which determines if class property transform has nothing to do and can bail out early. This also clears the way for correcting the logic around when temp vars are/aren't created in #7516.
@Dunqing Dunqing force-pushed the 12-02-refactor_transformer_class-properties_exit_transform_class_faster_if_nothing_to_do branch from 594ad33 to ebd11fb Compare December 3, 2024 07:48
@Dunqing Dunqing force-pushed the 12-02-refactor_transformer_class-properties_move_creating_temp_var_out_of_main_loop branch from 4a2961e to 7bd6350 Compare December 3, 2024 07:48
Base automatically changed from 12-02-refactor_transformer_class-properties_exit_transform_class_faster_if_nothing_to_do to main December 3, 2024 08:17
@graphite-app graphite-app bot merged commit 7bd6350 into main Dec 3, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 12-02-refactor_transformer_class-properties_move_creating_temp_var_out_of_main_loop branch December 3, 2024 08:23
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant