Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/class-properties): ResolvedPrivateProp type #7532

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 28, 2024

Pure refactor. lookup_private_property returns a tuple of 3 items, and future changes will make that 4. That's silly. Create a type ResolvedPrivateProp for it to return, so the various parts can have descriptive names.

Copy link

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 28, 2024
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7532 will not alter performance

Comparing 11-28-refactor_transformer_class-properties_resolvedprivateprop_type (dccff38) with main (71b3437)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_ branch from 6d505f7 to c855c2d Compare November 28, 2024 22:08
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch from d77528d to 2ea88cf Compare November 28, 2024 22:08
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch from 2ea88cf to 6b7c4f5 Compare November 28, 2024 22:23
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_ branch from c855c2d to 977a5fb Compare November 29, 2024 12:01
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch 2 times, most recently from 2509562 to 2728d4b Compare November 29, 2024 12:20
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_ branch from 977a5fb to 08170e2 Compare November 29, 2024 17:26
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch from 2728d4b to 0282aa3 Compare November 29, 2024 17:26
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_ branch from 08170e2 to a7e8ea6 Compare December 2, 2024 20:28
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch from 0282aa3 to b9200ad Compare December 2, 2024 20:28
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_ branch from a7e8ea6 to 2d1525e Compare December 3, 2024 01:59
@overlookmotel overlookmotel force-pushed the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch from b9200ad to 89d67f6 Compare December 3, 2024 01:59
@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2024 02:19
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2024
Copy link

graphite-app bot commented Dec 3, 2024

Merge activity

…7532)

Pure refactor. `lookup_private_property` returns a tuple of 3 items, and future changes will make that 4. That's silly. Create a type `ResolvedPrivateProp` for it to return, so the various parts can have descriptive names.
@Dunqing Dunqing force-pushed the 11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_ branch from 2d1525e to 367b6c8 Compare December 3, 2024 07:46
@Dunqing Dunqing force-pushed the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch from 89d67f6 to dccff38 Compare December 3, 2024 07:47
Base automatically changed from 11-28-refactor_transformer_class-properties_shortcut_static_class_take_symbolid_ to main December 3, 2024 08:05
@graphite-app graphite-app bot merged commit dccff38 into main Dec 3, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 11-28-refactor_transformer_class-properties_resolvedprivateprop_type branch December 3, 2024 08:12
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants