-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to v2 of the intellij gradle plugin #50
Migrate to v2 of the intellij gradle plugin #50
Conversation
maven(url = "https://maven.aliyun.com/repository/central") | ||
maven(url = "https://maven.aliyun.com/repository/public") | ||
maven(url = "https://maven.aliyun.com/repository/gradle-plugin") | ||
maven(url = "https://maven.aliyun.com/repository/gradle-core") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these URLs are needed for some reason then I can probably figure out how to retain them with the new changes.
The verify plugin build is failing due to the name of the plugin in |
Ci failed |
@IWANABETHATGUY it's going to fail until #50 (comment) is resolved. If you have a plugin name suggestion, I can change it. Maybe even just |
Running verify locally and found some compatibility issues with the existing LSP code and the targeted IDE versions as well. Went ahead and renamed the plugin and fixed these.
|
Still not sure why the ci is failed, since it is sucessed before? Only because of the naming? |
Running the main branch with the old command |
@Boshen ,Can you give a better naming? |
https://github.com/biomejs/biome-intellij/blob/main/src/main/resources/META-INF/plugin.xml, I found biome just use |
This will close out most (all?) of the pending dependabot PRs.