Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to v2 of the intellij gradle plugin #50

Conversation

nrayburn-tech
Copy link
Contributor

@nrayburn-tech nrayburn-tech commented Oct 9, 2024

  • Migrate to v2 of the IntelliJ gradle plugin (Mostly just syncing with the IntelliJ plugin template repo)
  • Update plugin name to fix CI errors during the verify action
  • Update target IDE versions due to incompatibilities with the LSP classes between different IDE versions

This will close out most (all?) of the pending dependabot PRs.

maven(url = "https://maven.aliyun.com/repository/central")
maven(url = "https://maven.aliyun.com/repository/public")
maven(url = "https://maven.aliyun.com/repository/gradle-plugin")
maven(url = "https://maven.aliyun.com/repository/gradle-core")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these URLs are needed for some reason then I can probably figure out how to retain them with the new changes.

@nrayburn-tech
Copy link
Contributor Author

The verify plugin build is failing due to the name of the plugin in src/main/resources/META-INF/plugin.xml. I don't think the name is supposed to contain intellij or plugin, but since it was existing I didn't want to change it.

@IWANABETHATGUY
Copy link
Collaborator

Ci failed

@nrayburn-tech nrayburn-tech mentioned this pull request Oct 9, 2024
@nrayburn-tech
Copy link
Contributor Author

@IWANABETHATGUY it's going to fail until #50 (comment) is resolved. If you have a plugin name suggestion, I can change it. Maybe even just oxc is fine.

@nrayburn-tech
Copy link
Contributor Author

Running verify locally and found some compatibility issues with the existing LSP code and the targeted IDE versions as well. Went ahead and renamed the plugin and fixed these.

  • Changed plugin name to Oxc.
  • Changed the target IDE version to only 2023 or 2024 versions.

@IWANABETHATGUY
Copy link
Collaborator

The verify plugin build is failing due to the name of the plugin in src/main/resources/META-INF/plugin.xml. I don't think the name is supposed to contain intellij or plugin, but since it was existing I didn't want to change it.

Still not sure why the ci is failed, since it is sucessed before? Only because of the naming?

@nrayburn-tech
Copy link
Contributor Author

Running the main branch with the old command runPluginVerifier and it doesn't fail locally, it only emits a warning (same as CI). My best guess is that the newer plugin and task is failing now instead of just showing a warning.

@IWANABETHATGUY
Copy link
Collaborator

Running verify locally and found some compatibility issues with the existing LSP code and the targeted IDE versions as well. Went ahead and renamed the plugin and fixed these.

  • Changed plugin name to Oxc.
  • Changed the target IDE version to only 2023 or 2024 versions.

@Boshen ,Can you give a better naming?

@IWANABETHATGUY
Copy link
Collaborator

https://github.com/biomejs/biome-intellij/blob/main/src/main/resources/META-INF/plugin.xml, I found biome just use Biome I think use Oxc is good enough.

@IWANABETHATGUY IWANABETHATGUY merged commit e5cc3f9 into oxc-project:main Oct 9, 2024
5 checks passed
@nrayburn-tech nrayburn-tech deleted the migrate-to-v2-of-intellij-gradle-plugin branch October 12, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants