Webstorm support #51
Merged
Webstorm support #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrayburn-tech
force-pushed
the
webstorm-support
branch
from
8242729 to
d7099a6
Compare
nrayburn-tech
force-pushed
the
webstorm-support
branch
from
54a2e4e to
9717cd5
Compare
nrayburn-tech
commented
Oct 9, 2024
| @@ -176,6 +176,9 @@ jobs: | |||
| name: Verify plugin | |||
| needs: [ build ] | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| platformType: ['IU', 'WS'] | |||
There was a problem hiding this comment.
This is so that we execute the verify step on both IntelliJ Ultimate and Webstorm. It ensures that the APIs we use in our plugin are compatible with both projects. I think we might also be able to only depend on Webstorm and assume that IntelliJ Ultimate contains everything from Webstorm and more.
I'm open to changing this PR around to function that way if that is the preferred approach.
IWANABETHATGUY
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://plugins.jetbrains.com/docs/intellij/plugin-compatibility.html#declaring-incompatibility-with-module
Depends on #50.