[full-ci][tests-only] Refactor service health and ready url in tests #10808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
santizeServiceUrlInTests
branch
2 times, most recently
from
7fff1a5 to
819e885
Compare
amrita-shrestha
requested review from
ishabaral,
SagarGi,
saw-jan,
nabim777,
PrajwolAmatya,
anon-pradip and
prashant-gurung899
amrita-shrestha
force-pushed
the
santizeServiceUrlInTests
branch
from
819e885 to
1f17ee3
Compare
2 tasks
amrita-shrestha
force-pushed
the
santizeServiceUrlInTests
branch
from
1f17ee3 to
cae9910
Compare
9 tasks
| | %base_url_hostname%:9297/healthz | antivirus | | ||
| When a user sends "GET" request to the following url with no authentication | ||
| | endpoint | service | | ||
| | http://%base_url_hostname%:9297/healthz | antivirus | |
There was a problem hiding this comment.
so we were sending request to https instead of http
There was a problem hiding this comment.
we are sending request to service health endpoint i.e http://hostname:service_debug_port/...
amrita-shrestha
force-pushed
the
santizeServiceUrlInTests
branch
2 times, most recently
from
bf33695 to
64e9ec5
Compare
|
LGTM 👍 |
amrita-shrestha
force-pushed
the
santizeServiceUrlInTests
branch
2 times, most recently
from
5c988c1 to
59447d3
Compare
saw-jan
reviewed
Dec 31, 2024
tests/acceptance/features/apiAntivirus/serviceAvailabilityCheck.feature
Outdated
Show resolved
Hide resolved
amrita-shrestha
force-pushed
the
santizeServiceUrlInTests
branch
from
59447d3 to
1f32eec
Compare
saw-jan
approved these changes
Dec 31, 2024
amrita-shrestha
force-pushed
the
santizeServiceUrlInTests
branch
from
1f32eec to
acc993a
Compare
|
ownclouders
pushed a commit
that referenced
this pull request
Dec 31, 2024
[full-ci][tests-only] Refactor service health and ready url in tests
ownclouders
pushed a commit
that referenced
this pull request
Jan 1, 2025
[full-ci][tests-only] Refactor service health and ready url in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem lies in the test code, which is sending requests to the following incorrect URL: https://localhost:9200/ocalhost:9229/healthz and https://localhost:9200/ocalhost:9229/readyz
As a result, the server returns a 200 status code, but the request is not directed to the intended endpoint, causing tests to pass erroneously.
This PR update test code base to send request to proper url
Note: This PR isolates the problematic service into a separate scenario for testing. Once issue #10661 is resolved, the scenario separation introduced in this PR should be reverted.
A follow-up QA point has been added in #10316.
Related Issue
Part of
500status code #10661Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: