Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testplan for #10281 - service health and readiness checks #10316

Open
1 of 2 tasks
dragonchaser opened this issue Oct 16, 2024 · 3 comments
Open
1 of 2 tasks

Testplan for #10281 - service health and readiness checks #10316

dragonchaser opened this issue Oct 16, 2024 · 3 comments
Assignees
Labels

Comments

@dragonchaser
Copy link
Contributor

dragonchaser commented Oct 16, 2024

We need to test the /healthz and /readyz of every service mentioned in #10281 for functionality (e2e). Therefore we need additional tests in our PHP-Suite.

IMHO there is no need to test them in k8s or k3s. It should be sufficient to check the output of the two endpoints with their conditions being met or unmet.

refs #8783

Tests:

Known bugs:

@ScharfViktor
Copy link
Contributor

we have two ways(or more) how to check health of the service

service nats example:
curl http://127.0.0.1:9234/healthz - 200
and using CLI ocis/bin/ocis nats health - doesn't work (`ocis/bin/ocis nats version - also doesn't work)

in addition to checking the endpoinds we can check CLI using cliCommand suite. @dragonchaser should we fix cli health command for all services?

@ScharfViktor ScharfViktor self-assigned this Oct 16, 2024
@saw-jan saw-jan changed the title Testplan for #10281 Testplan for #10281 - service health and readiness checks Oct 29, 2024
@PrajwolAmatya PrajwolAmatya self-assigned this Nov 21, 2024
@PrajwolAmatya
Copy link
Contributor

PrajwolAmatya commented Nov 29, 2024

  • during test stop the nats server and start again, check for /healthz and /readyz

Currently, there isn't any command to stop the nats server. Starting ocis with OCIS_EXCLUDE_RUN_SERVICES=nats and running nats separately with ocis/bin/ocis nats server doesn't seem feasible in CI. Trying to get pid for nats and kill pid will crash the ocis.

CC. @ScharfViktor

@PrajwolAmatya
Copy link
Contributor

Need to wait for #10715 to be completed which will cover stopping and starting single ocis service. So, moving this to blocked for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

No branches or pull requests

3 participants