Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file picker #2

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Add file picker #2

merged 1 commit into from
Aug 27, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Aug 25, 2020

Add basic file/location picker

Screenshot 2020-08-26 at 11 05 02

@LukasHirt LukasHirt added the enhancement New feature or request label Aug 25, 2020
@LukasHirt LukasHirt self-assigned this Aug 25, 2020
@LukasHirt LukasHirt force-pushed the feature/file-picker branch 2 times, most recently from f764550 to e9f4c4e Compare August 26, 2020 09:03
@LukasHirt LukasHirt marked this pull request as ready for review August 26, 2020 09:05
@LukasHirt
Copy link
Collaborator Author

@kulmann @PVince81 Ready for review. Sorry, it's all just in two commits. I was originally writing the code in Phoenix repo and when I moved it here I lost commit history.

Copy link

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, nothing critical 👍

See comments

README.md Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Show resolved Hide resolved
src/components/FilePicker.vue Show resolved Hide resolved
src/components/ListHeader.vue Outdated Show resolved Hide resolved
src/components/ListResources.vue Outdated Show resolved Hide resolved
<div class="oc-login-card">
<div class="oc-login-card-body">
<h3 class="oc-login-card-title">
Welcome to ownCloud

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a bit generic if it's only the file picker

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be later themeable but for now, I'll put the ownCloud File picker

@@ -0,0 +1,99 @@
{
"7z": "package-x-generic",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should eventually load those from the original server, once we provide an endpoint or file to expose them

src/helpers/resources.js Outdated Show resolved Hide resolved
@LukasHirt LukasHirt merged commit ab37342 into master Aug 27, 2020
@LukasHirt LukasHirt deleted the feature/file-picker branch August 27, 2020 14:31
@LukasHirt LukasHirt mentioned this pull request Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants