Add tests and release jobs into drone #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is built on top of #2 After it gets merged I'll do a rebase. |
LukasHirt
force-pushed
the
drone/release-job
branch
from
1623cab to
6cb8280
Compare
|
Had to change the node images because version 12 is having troubles with the module type in package.json (see manuelbieh/geolib#208) |
micbar
reviewed
Aug 27, 2020
| }, | ||
| 'title': ctx.build.ref.replace("refs/tags/v", ""), | ||
| 'note': 'dist/CHANGELOG.md', |
There was a problem hiding this comment.
You need to build the changelog first. The other alrready built changelog is from another pipeline. Also you need only the changes for that specific tag. Example in https://github.com/owncloud/ocis/blob/master/.drone.star#L565
There was a problem hiding this comment.
I see, thanks! I added it.
|
Had troubles with getting the calens from github so removed it from makefile and used calens image and the command directly in the drone. |
LukasHirt
force-pushed
the
drone/release-job
branch
from
e773ddd to
2b89600
Compare
LukasHirt
force-pushed
the
drone/release-job
branch
from
2b89600 to
87ae396
Compare
micbar
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps that should happen: