[TECHNICAL] Technical improvements for user quota #4525
+257
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joragua
force-pushed
the
technical/technical_improvements_for_quota
branch
from
8e7bfe9 to
2f0df52
Compare
11 tasks
joragua
force-pushed
the
technical/technical_improvements_for_quota
branch
from
1f95f15 to
8d5c35f
Compare
JuancaG05
requested changes
Dec 12, 2024
owncloudApp/src/main/java/com/owncloud/android/presentation/common/DrawerViewModel.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt
Outdated
Show resolved
Hide resolved
owncloudData/src/main/java/com/owncloud/android/data/user/db/UserDao.kt
Outdated
Show resolved
Hide resolved
|
|
||
| ocLocalUserDataSource.deleteQuotaForAccount(OC_ACCOUNT_NAME) | ||
| val userQuota = ocLocalUserDataSource.getQuotaForAccountAsFlow(OC_ACCOUNT_NAME).first() | ||
| assertEquals(userQuotaEntity.toModel(), userQuota) |
There was a problem hiding this comment.
Suggested change
| assertEquals(userQuotaEntity.toModel(), userQuota) | |
| assertEquals(OC_USER_QUOTA, userQuota) |
.../java/com/owncloud/android/data/user/datasources/implementation/OCLocalUserDataSourceTest.kt
Outdated
Show resolved
Hide resolved
joragua
force-pushed
the
technical/technical_improvements_for_quota
branch
from
32ed01c to
d7f96a2
Compare
joragua
force-pushed
the
technical/technical_improvements_for_quota
branch
2 times, most recently
from
1503d9d to
3453331
Compare
…dQuotaAsStreamUseCase`)
… remove unnecessary ones from `DrawerViewModelTest`
…edQuotaAsStreamUseCase`
…ll possible quota cases
joragua
force-pushed
the
technical/technical_improvements_for_quota
branch
from
3453331 to
a9576a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4521
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA