Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECHNICAL] Technical improvements for user quota #4521

Open
8 of 11 tasks
joragua opened this issue Dec 4, 2024 · 1 comment · May be fixed by #4525
Open
8 of 11 tasks

[TECHNICAL] Technical improvements for user quota #4521

joragua opened this issue Dec 4, 2024 · 1 comment · May be fixed by #4525
Assignees
@joragua
Labels
Estimation - 2 (S) Technical
Milestone
4.5 - Current

Comments

@joragua
Copy link
Collaborator

joragua commented Dec 4, 2024 •
edited
Loading

Right now, the user quota is fetched (getStoredQuota method) from the database multiple times in DrawerActivity because it is not get as a Flow. In this issue we are going to improve performance by fetching the user quota as Flow and remove unnecessary calls from the activity.

TASKS

  • Research (if needed)
  • Create branch technical/technical_improvements_for_quota
  • Development tasks
    • Create a new use case (GetStoredQuotaAsStreamUseCase)
    • Remove unnecessary calls from DrawerActivity
    • Fix some elements from drawer
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch technical/technical_improvements_for_quota
@jesmrec jesmrec added this to the 4.5 - Current milestone Dec 5, 2024
@joragua joragua self-assigned this Dec 10, 2024
@joragua joragua linked a pull request Dec 11, 2024 that will close this issue
Open
2 tasks
@joragua joragua linked a pull request Dec 11, 2024 that will close this issue
[TECHNICAL] Technical improvements for user quota #4525
Open
2 tasks
@joragua
Copy link
Collaborator Author

joragua commented Jan 9, 2025 •
edited
Loading

Apart from technical work, the progress bar in the drawer has been removed when the quota is unlimited.

With progress bar Without progress bar
Captura de pantalla 2025-01-09 a las 10 47 26 Captura de pantalla 2025-01-09 a las 10 40 25

Also, the color of the progress bar has changed to red when the quota is nearing:

Previous version New version
Captura de pantalla 2025-01-09 a las 11 23 46 Captura de pantalla 2025-01-09 a las 11 19 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joragua joragua

Labels
Estimation - 2 (S) Technical
Projects
None yet
Milestone
4.5 - Current
Development

Successfully merging a pull request may close this issue.

[TECHNICAL] Technical improvements for user quota owncloud/android
2 participants
@jesmrec @joragua