Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double libs loading #4855

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Fix double libs loading #4855

merged 1 commit into from
Nov 24, 2024

Conversation

ArturKnopik
Copy link
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed:
#4770

How to test:

  1. Run server
  2. count "Using LuaJIT 2.1.0-beta3" or Lua 5.4 related string
    note: global.lua is loading dofile('data/lib/lib.lua') that loads dofile('data/lib/debugging/lua_version.lua') that print lua version

@ghost ghost linked an issue Nov 24, 2024 that may be closed by this pull request
[Bug]: Double load global.lua #4770
Closed
4 tasks
@ghost ghost requested review from ranisalt, nekiro and MillhioreBT November 24, 2024 16:37
ramon-bernardo
ramon-bernardo approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@ramon-bernardo ramon-bernardo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Npcs::load() is called within ScriptingManager::loadScriptSystems(), however, global.lua is already loaded at this point.

image

@ranisalt ranisalt merged commit 6f05ea8 into otland:master Nov 24, 2024
16 checks passed
ArturKnopik added a commit to ArturKnopik/forgottenserver that referenced this pull request Nov 25, 2024
@ArturKnopik
Revert "fix double libs loading (otland#4855)"
a0ff47b 
This reverts commit 6f05ea8.
ghost pushed a commit that referenced this pull request Nov 25, 2024
@ArturKnopik
Revert "fix double libs loading (#4855)" (#4859)
ccfd367 
This reverts commit 6f05ea8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramon-bernardo ramon-bernardo ramon-bernardo approved these changes

@ranisalt ranisalt Awaiting requested review from ranisalt

@nekiro nekiro Awaiting requested review from nekiro

@MillhioreBT MillhioreBT Awaiting requested review from MillhioreBT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Double load global.lua
3 participants
@ArturKnopik @ramon-bernardo @ranisalt