Add pblog args #47
Add pblog args #47
Conversation
…nks; add rosdeps Signed-off-by: Michael Anderson <[email protected]>
fix rosdep
Signed-off-by: Michael Anderson <[email protected]>
Signed-off-by: Michael Anderson <[email protected]>
|
This looks good, I will open the discussion about where the best default spot for the files is. Perhaps a directory called ~/logs would be sensible, it matches the buoy, and also keeps things from not being dependent upon where one starts things from. Pros and cons here, perhaps fine as is, especially as the batch-file processing (#140) is over-riding this location... |
Other options would be in the colcon workspace logs directory that already exists. Or, in ~/.ros/logs |
|
I think the workspace logs should be kept for their build process, I often delete that if I need a fresh start. Maybe similar for .ros/logs, and these logs aren't ros. maybe ~/.pblogs/... ? |
|
|
Signed-off-by: Michael Anderson <[email protected]>
|
@hamilton8415 ready for another check |
Signed-off-by: Michael Anderson <[email protected]>
|
Hmm, After pulling mbari_wec_gz and mbari_wec_util when I run it I am now seeing now files in the pblog directory (running with the batch proccessor). Also, previous to that I noticed that the log files are only outputing new data every second, this was with a RTF of 11, so perhaps it's using wall clock to update the output instead of sim time. That may be an issue in #40 rather than here... |
|
I'm not sure I follow about the pblog files with batch. Regarding the logger rate, I did realize I forgot to mention the sim |
|
@hamilton8415 @rhenthorn I think if we are happy with the changes in this specific branch, we could merge to #44 and fix the rest there. |
|
Yes, I think your suggested merge into #44 won't hurt us, consolidation... |
|
Done. We can continue updates/fixes in #44 |
* Created buoy-type logging for buoy_sim * Clean up formatting to match buoy logging * Fix flake8 and pep8 erros * Fix flake8 and pep8 errors 2 * Fix flake8 and pep8 errors 3 * Formatting erros in launch script - empty line needed * Add epoch seconds offset to simulation time, log that value as the timestamp * Corrected header line * Move log home and file interval to class attributes * Add pblog args (#47) * add launch args for log paths; add ros2 param for interval; fix symlinks; add rosdeps Signed-off-by: Michael Anderson <[email protected]> * Update package.xml fix rosdep * fix atexit gzip Signed-off-by: Michael Anderson <[email protected]> * linter Signed-off-by: Michael Anderson <[email protected]> * update default pblog root; stop gzipping at exit; fix gzipping at start Signed-off-by: Michael Anderson <[email protected]> * remove unused import Signed-off-by: Michael Anderson <[email protected]> * Correct faulty CrossbowID value from 5 to 3 --------- Signed-off-by: Michael Anderson <[email protected]> Co-authored-by: Rich Henthorn <[email protected]> * Corrected error: using pc_header to calculate the 'blank' cells in a record when xb_header, bc_header, and sc_header should have been used * tweak msg time a little Signed-off-by: Michael Anderson <[email protected]> * Fix pbcmd terminate (#50) * add async proxy to await future for pack rate calls Signed-off-by: Michael Anderson <[email protected]> * typo Signed-off-by: Michael Anderson <[email protected]> --------- Signed-off-by: Michael Anderson <[email protected]> * line buffered csv Signed-off-by: Michael Anderson <[email protected]> * linter Signed-off-by: Michael Anderson <[email protected]> * Update sim_pblog/sim_pblog/sim_pblog.py * fix data loss with log rolling Signed-off-by: Michael Anderson <[email protected]> * bugfix Signed-off-by: Michael Anderson <[email protected]> * linter Signed-off-by: Michael Anderson <[email protected]> * linter Signed-off-by: Michael Anderson <[email protected]> * Convert SC values from newtons and meters to lbs and inches --------- Signed-off-by: Michael Anderson <[email protected]> Co-authored-by: Michael Anderson <[email protected]>
and other fixes
required by osrf/mbari_wec_gz#140