Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log files #114

Closed
mabelzhang opened this issue Jan 12, 2023 · 7 comments · Fixed by osrf/mbari_wec_utils#44, osrf/mbari_wec_utils#47 or #140
Closed

Log files #114

mabelzhang opened this issue Jan 12, 2023 · 7 comments · Fixed by osrf/mbari_wec_utils#44, osrf/mbari_wec_utils#47 or #140
Assignees

Comments

@mabelzhang
Copy link
Collaborator

Replicate csv log files from physical buoy system.

On the physical system, filenames and folders are specific to the time of day. Think about the best way to do this for a faster-than-real-time simulated system.
hamilton8415: "Perhaps it's as simple as each simulation start creates a new logfile directory with a name specific to the start-time, then the filenames proceed forward from there representing simulation time."

Assign to rhenthorn upon agreement

@rhenthorn
Copy link
Collaborator

As long as the data messages contain simulation time there should not be an issue.

@rhenthorn
Copy link
Collaborator

I have begun working on this issue. Created henthorn/sim_pblog branch in buoy_msgs repo.

Used the python controller template as a starting point for this node - handy as the template controller subscribes to all the topics needed.

@andermi
Copy link
Collaborator

andermi commented Feb 28, 2023

@rhenthorn would you please add a launch argument (to controller.launch.py or whatever you may have changed the name to) to specify a custom log directory?

@rhenthorn
Copy link
Collaborator

The node sim_pblog has been added to buoy_msgs repo branch 'henthorn/sim_pblog'. Some items to resolve:

  1. Add a custom log folder as a launch argument
  2. First field 'epoch seconds' in the log file (use simulation time - starts at 0.0, or add sim time to current epoch seconds?)
  3. Integrate into buoy_gazebo to launch sim_pblog with the simulation

Thanks everyone for your help and patience.

@rhenthorn
Copy link
Collaborator

Also add to items to resolve

  1. insert dependencies in packages.xml

@andermi
Copy link
Collaborator

andermi commented Mar 17, 2023

If you wouldn't mind starting a PR in the buoy_msgs repo, we could start reviewing :)

@mabelzhang
Copy link
Collaborator Author

PR osrf/mbari_wec_utils#44

@mabelzhang mabelzhang linked a pull request Apr 3, 2023 that will close this issue
This was linked to pull requests Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants